Remove surelog libs out of own folder, use soversion #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hs-apotell
reviewed
Sep 2, 2023
|
yosys-systenverilog-plugin test is faiing here, can't merge. |
I can take a look, though it seems unrelated to this PR. As part of my Mac PR on the yosys plugins, I've removed all the custom conda stuff so maybe this will be more reliable/easily maintainable in the nearish future. |
|
@timkpaine Looks like this is the root cause of the failure of the plugin: |
|
@alaindargelas pretty sure its this: chipsalliance/synlig@ec729d5 |
|
@timkpaine correct. So you can make this PR official. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel of chipsalliance/UHDM#1002
libinstead oflib/surelog, python files moved tolib/surelog-python(open to other options, should probably move to a real python package)SOVERSIONso that lib/libsurelog.so is now a symlink, and we install a versioned lib/libsurelog.so..